Bug#841146: diffoscope: Failure of test_superblock

[Mattia Rizzolo]

Control: tag -1 pending

On Sun, Oct 23, 2016 at 05:00:27PM -0400, Leo Famulari wrote:
> When I format the code correctly, the test is skipped and we can build
> diffoscope successfully:

cool!

> > >> Though I'm using pytest 3.0.3.
> > >> That test is skipped by using pytest.mark.skip(), which I don't see in
> > >> the docs of pytest for 2.7.
> > >> The changelog of pytest tells me pytest.mark.skip() is recognized as a
> > >> skipping marker starting from 2.9¹.  Is there any chance you can instead
> > >> upgrade pytest in your distribution?
> > > 
> > > We are working on upgrading the core Python packages like pytest and
> > > Setuptools but we can't do it overnight.
> > > 
> > >> If so I'll add a versioned dependency on setup.py, otherwies I can
> > >> always turn that pytest.mark.skip() into a pytest.mark.skipif(True),
> > >> which is IMHO ugly but quick and effective for solving this bug, I
> > >> think.  Can you also try to convert that marking in
> > >> tests/comparators/utils.py:49 to confirm?
> 
> I don't think it's necessary for you to make that change in diffoscope;
> we can skip the test in our packaging while we work on upgrading pytest.
> But of course it's up to you.

I don't see why we can't :)
https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=fa07622

Really the only gain of pytest.mark.skip() over pytest.mark.skipif() is
that the former is a bit shorter.

I'm trying to finish up some things and pull up a release this week, if
you want you could just wait for that instead of including a patch.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20161023/19556798/attachment.sig>