[Reproducible-builds] Minimising work needed for this build-path issue
Daniel Kahn Gillmor
dkg at fifthhorseman.net
Tue Nov 1 16:16:54 UTC 2016
On Tue 2016-11-01 11:56:00 -0400, Ximin Luo wrote:
> But the TIMESTAMP patch is for __TIMESTAMP__ whereas our
> currently-existing Debian patches are only for __DATE__ and __TIME__.
ah, right. sorry i totally missed that, and of course it makes sense.
Perhaps you could call that out explicitly in SRD_Debug.txt, and modify
the documentation related to SOURCE_DATE_EPOCH as well.
> I was going to send the __FILE__ patch in a separate email later
> yes. Just so it's a bit less overwhelming for the reviewers.
If you're sending in the __TIMESTAMP__ changes and the =-selection
changes, i don't think the __FILE__ changes are overwhelming. I'd
suggest sending the entire series, perhaps as an e-mail thread (e.g. via
git-send-email), with SRD_Debug.txt as an introduction e-mail/cover
That way the recipients see the individual changes in sensible,
non-overwhelming pieces, but they also don't have to wait for receipt of
the completed series in case they have time to review it in full.
Thanks for this work -- it is a significant contribution to GCC, and to
the momentum behind reproducible-builds in general.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 930 bytes
Desc: not available
More information about the Reproducible-builds