[PATCH] reproducible Debian: filter Environment section from buildinfo files

[Mattia Rizzolo]

On Mon, Nov 07, 2016 at 01:41:00PM +0000, HW42 wrote:
> I removed the filter from Reiner and replaced it with a 'sed' filtering
> out the .buildinfo entries from the .changes file. So diffoscope should
> not compare the .buildinfos (and the files refered by them) at all.

Ah, right, I missed the filter_buildinfo_files → filter_changes_files
change… sorry
(this still feels "unclean", same as removing fields from .buildinfo, so
no increase in the "dirt count")

btw, I need to check that again (didn't have the right tuit to do it),
but comparing .changes with different .buildinfo but otherwise
reproducible .deb, diffoscope should already return 0 and no diffs (we
could argue whether this should have be better as an opt-in option
rather than hardcoded, but well…
See c61f41c5128094508d6fff8b746cecc3841f6b27 in diffoscope.git

but:

> > I'll file a diffoscope bug after this email.
> 
> Once diffoscope has a --ignore-buildinfo options for comparing .changes
> you can just drop the filter_changes_files function and pass the option
> to diffoscope.

personally I'd prefer to see .buildinfo differences together with the
.deb diffs.  They can provide useful insight (that currently we also
have because the 2 build environments are documented elsewhere).  Just
that diffoscope should really not compare files that have already been
compared.  It's just very hard to do, on the same level of the parallel
diffoscope one maybe…

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20161107/c9111b35/attachment.sig>