Bug#845556: dpkg: should not generate .buildinfo files for source only uploads

[Holger Levsen]

Package: dpkg
Version: 1.18.15
Severity: normal

Hi Guillem,

the subject basically says it all, dpkg should not generate .buildinfo
files for source only uploads, as they are totally pointless for those.

(I'm also not even sure whether you had implemented in most recent
uploads, but I thought I better file this is a bug which you can easily
close, instead of risking to loose this patch, which floated around on
irc:


>From e774e1e19a0aa3ed21603949385bf1f0ac1452e9 Mon Sep 17 00:00:00 2001
From: James Clarke <jrtc27 at jrtc27.com>
Date: Fri, 11 Nov 2016 00:55:43 +0000
Subject: [PATCH] dpkg-buildpackage: Don't generate .buildinfo for source-only
 builds

---
 scripts/dpkg-buildpackage.pl | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/scripts/dpkg-buildpackage.pl b/scripts/dpkg-buildpackage.pl
index b1d644d..32e1028 100755
--- a/scripts/dpkg-buildpackage.pl
+++ b/scripts/dpkg-buildpackage.pl
@@ -561,13 +561,15 @@ if (build_has_any(BUILD_BINARY)) {
     withecho(@rootcommand, @debian_rules, $binarytarget);
 }
 
-run_hook('buildinfo', 1);
+run_hook('buildinfo', build_has_any(BUILD_BINARY));
 
-push @buildinfo_opts, "--build=$build_types" if build_has_none(BUILD_DEFAULT);
-push @buildinfo_opts, "--buildinfo-id=$buildinfo_id" if $buildinfo_id;
-push @buildinfo_opts, "--admindir=$admindir" if $admindir;
+if (build_has_any(BUILD_BINARY)) {
+    push @buildinfo_opts, "--build=$build_types" if build_has_none(BUILD_DEFAULT);
+    push @buildinfo_opts, "--buildinfo-id=$buildinfo_id" if $buildinfo_id;
+    push @buildinfo_opts, "--admindir=$admindir" if $admindir;
 
-withecho('dpkg-genbuildinfo', @buildinfo_opts);
+    withecho('dpkg-genbuildinfo', @buildinfo_opts);
+}
 
 run_hook('changes', 1);
 
-- 
2.10.2


Thanks for maintaining dpkg!

-- 
cheers,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20161124/ac77d497/attachment.sig>