Bug#848249: diffoscope: set_locale needs to call tzset

Chris Lamb lamby at debian.org
Thu Dec 15 17:33:20 UTC 2016


Hi Brett,

> Tags: patch

Thanks for the patch! However, you do not actually call set_locale in the
gzip test, you merely import it.

Whilst you could "just" add this, I was wondering if you could ensure that
pytest *always* calls this so other tests are not affected. I believe there
is some magic fixture name/decorator in pytest for this.

If you could provide this as a separate patch to the tzset bit, then that
would be ideal.

(I'll apply just the tzset bit now, however.)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-



More information about the Reproducible-builds mailing list