Bug#848249: diffoscope: set_locale needs to call tzset

Chris Lamb lamby at debian.org
Thu Dec 15 21:33:15 UTC 2016


Hi Brett,

> So the whole thing with the set_locale test fixture is a little subtle.  The
> best reference I found for this is
> <http://doc.pytest.org/en/latest/fixture.html#autouse-fixtures-xunit-setup-on-steroids>.

Very nice research, thank you. :)

> If you want to make sure it runs before any test, we can do that too.  I've
> attached a patch for that as well.

Applied with thanks. I think this better than relying on the import doing the
right thing, especially as its likely that someone armed with pylint is likely
to remove such an apparent no-op.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-



More information about the Reproducible-builds mailing list