Bug#848373: diffoscope: Missing install dependency on colordiff

[Christoph Biedl]

Package: diffoscope
Version: 63
Severity: important
Tags: newcomer

Dear Maintainer,

diffoscope requires colordiff to run but does neither depend on the
package nor check for its presence to perhaps handle the situation
gracefully. And so I got:

--- v1/gkrellmwireless_2.0.3-1_amd64.changes
+++ v2/gkrellmwireless_2.0.3-1_amd64.changes
├── Files
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 290, in main
    sys.exit(run_diffoscope(parsed_args))
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 268, in run_diffoscope
    output_text(difference, print_func=print_func, color=color)
  File "/usr/lib/python3/dist-packages/diffoscope/presenters/text.py", line 60, in output_text
    print_details(difference, print_func, color)
  File "/usr/lib/python3/dist-packages/diffoscope/presenters/text.py", line 49, in print_details
    print_difference(detail, print_func, color)
  File "/usr/lib/python3/dist-packages/diffoscope/presenters/text.py", line 34, in print_difference
    diff_output = color_unified_diff(difference.unified_diff)
  File "/usr/lib/python3/dist-packages/diffoscope/__init__.py", line 69, in tool_check
    raise RequiredToolNotFound(command)
diffoscope.exc.RequiredToolNotFound: colordiff


Please add colordiff to the Depends: line, thanks.

    Christoph

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: unable to detect

Versions of packages diffoscope depends on:
ii  python3-libarchive-c   2.1-3.1
ii  python3-magic          1:5.29-1
ii  python3-pkg-resources  28.7.1-1
pn  python3:any            <none>

Versions of packages diffoscope recommends:
ii  acl                                            2.2.52-3
pn  binutils-multiarch                             <none>
ii  bzip2                                          1.0.6-8
pn  caca-utils                                     <none>
pn  colord                                         <none>
ii  colordiff                                      1.0.16-1
pn  cpio                                           <none>
pn  default-jdk-headless | default-jdk | java-sdk  <none>
pn  enjarify                                       <none>
pn  fontforge-extras                               <none>
pn  fp-utils                                       <none>
pn  genisoimage                                    <none>
ii  gettext                                        0.19.8.1-1
pn  ghc                                            <none>
pn  ghostscript                                    <none>
ii  gnupg                                          2.1.16-2
pn  llvm                                           <none>
pn  mono-utils                                     <none>
pn  pdftk                                          <none>
pn  poppler-utils                                  <none>
pn  python3-argcomplete                            <none>
ii  python3-debian                                 0.1.29
pn  python3-guestfs                                <none>
pn  python3-progressbar                            <none>
ii  python3-rpm                                    4.12.0.2+dfsg1-1
ii  python3-tlsh                                   3.4.4+20151206-1+b1
pn  rpm2cpio                                       <none>
pn  sng                                            <none>
pn  sqlite3                                        <none>
pn  squashfs-tools                                 <none>
ii  unzip                                          6.0-20
ii  vim-common                                     2:8.0.0095-1
ii  xxd                                            2:8.0.0095-1
ii  xz-utils                                       5.2.2-1.2

Versions of packages diffoscope suggests:
ii  libjs-jquery  3.1.1-1

-- no debconf information

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20161216/51f7d1e5/attachment.sig>