Bug#843531: diffoscope: walks through packages twice when comparing two .changes

[Chris Lamb]

tags 843531 - patch
thanks

> diffoscope: walks through packages twice when comparing two .changes

Thu 22 13:17 <        mapreri > lamby: btw, your commit does seem to do 
                                the work, but I'm still not confident  
                                as to whether there are other  
                                implications or whatnot, so I'd prefer  
                                to stare at it some more before merging 
                                on master 
Thu 22 13:18 <          lamby > mapreri: Could you easily construct a  
                                test? 
Thu 22 13:18 <          lamby > I'm not committing it without one. (In  
                                fact, I regret adding the patch tag.) 
Thu 22 13:20 < mapreri> ah, no, it's broken :( 
Thu 22 13:20 < mapreri> if you try to diff 2 .buildinfo it won't  
                        recurse over the .debs anymore 
Thu 22 13:20 < mapreri> and no, I haven't forged a nice test for the  
                        testsuite, just running it against an  
                        unreproducible package                         
Thu 22 13:20 < mapreri> I should probably do that, but I'm not sure
                        about how to do it.

[..]

Thu 22 13:23 <        mapreri > lamby: if it wasn't clear enough, this is what happens (first with your patch, after without https://paste.debian.net/plain/903968).  if comparing .changes runs as wanted.


(Using mock module might be helpful for a testcase)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-