Bug#849142: [PATCH] Update dex_expected_diffs and test requirement to ensure test compatibility with enjarify >= 1.0.3. (Closes: #849142)

Daniel Shahaf danielsh at apache.org
Sat Dec 24 20:33:58 UTC 2016


Chris Lamb wrote on Sat, Dec 24, 2016 at 18:57:38 +0000:
> @@ -30,6 +31,17 @@ from test_java import javap_version
> +def enjarify_version():
> +    # Module enjarify.typeinference appeared in enjarify 1.0.3.  We use a call
> +    # directly to the python3 binary over importing with this module to escape
> +    # virtualenvs, etc.
> +    if subprocess.call(
> +        ('python3', '-c', 'import enjarify.typeinference'),

Use sys.executable instead of hardcoding 'python3', to handle the case
that there's more than one python3 binary on the system?

(This would be correct for straight python3; is it also correct with
virtualenvs at play?)

Cheers,

Daniel

> +        stderr=subprocess.PIPE,
> +    ) == 0:
> +        return '1.0.3'
> +    return '1.0.2'



More information about the Reproducible-builds mailing list