Bug#850758: diffoscope: redundant undecoded AndroidManifest.xml (Binary XML) comparison in APK comparator

Emanuel Bronshtein e3amn2l at gmx.com
Mon Jan 9 23:13:15 UTC 2017


Package: diffoscope
Version: 67
Severity: normal

Dear Maintainer,

The result of comparing AndroidManifest.xml (Binary XML) file from APK file in apk.py comparator is shown twice, 
first, as AndroidManifest.xml (XML file decoded from original file by apktool)
second, as original/AndroidManifest.xml (the original undecoded binary file)

fix:
	1. if there is a difference in decoded AndroidManifest.xml file, remove the original/AndroidManifest.xml.
	   if there is no difference in AndroidManifest.xml but original/AndroidManifest.xml differ, show "No file format specific differences found inside, yet data differs" message (which shown by diffoscope in similar scenarios [when tool failed to find differences])

	2. it will be better to indicate the AndroidManifest.xml type, such as for example:
		show AndroidManifest.xml          as "AndroidManifest.xml (decoded)"
		show original/AndroidManifest.xml as "AndroidManifest.xml (original / undecoded)"

examples:
	https://verification.f-droid.org/org.opengemara.shiurim_2.apk.diffoscope.html
	https://verification.f-droid.org/org.systemcall.scores_2.apk.diffoscope.html

TXT result example:

├── AndroidManifest.xml
@@ -1,9 +1,9 @@
│  <?xml version="1.0" encoding="utf-8"?>
│ -<manifest android:versionCode="2" android:versionName="1.1" package="org.systemcall.scores" platformBuildVersionCode="17" platformBuildVersionName="4.2.2-576024"
│ +<manifest android:versionCode="2" android:versionName="1.1" package="org.systemcall.scores" platformBuildVersionCode="17" platformBuildVersionName="4.2.2-1425461"

├── original/AndroidManifest.xml
@@ -1,17 +1,17 @@
│ -00000000: 0300 0800 9808 0000 0100 1c00 9c04 0000  ................
│ +00000000: 0300 0800 9c08 0000 0100 1c00 a004 0000  ................
│  00000010: 1f00 0000 0000 0000 0000 0000 9800 0000  ................
│  00000020: 0000 0000 0000 0000 1a00 0000 3400 0000  ............4...
│  00000030: 5200 0000 7600 0000 9000 0000 9c00 0000  R...v...........
│  00000040: aa00 0000 b800 0000 c400 0000 d600 0000  ................
│  00000050: 2e01 0000 3201 0000 4401 0000 7801 0000  ....2...D...x...
│  00000060: ac01 0000 c001 0000 ee01 0000 f801 0000  ................
│ -00000070: 0002 0000 1c02 0000 3002 0000 4a02 0000  ........0...J...
│ -00000080: 5e02 0000 aa02 0000 c802 0000 d802 0000  ^...............
│ -00000090: 1003 0000 2403 0000 6803 0000 bc03 0000  ....$...h.......
│ +00000070: 0002 0000 1e02 0000 3202 0000 4c02 0000  ........2...L...
│ +00000080: 6002 0000 ac02 0000 ca02 0000 da02 0000  `...............
│ +00000090: 1203 0000 2603 0000 6a03 0000 be03 0000  ....&...j.......
│  000000a0: 0b00 7600 6500 7200 7300 6900 6f00 6e00  ..v.e.r.s.i.o.n.
│  000000b0: 4300 6f00 6400 6500 0000 0b00 7600 6500  C.o.d.e.....v.e.
│  000000c0: 7200 7300 6900 6f00 6e00 4e00 6100 6d00  r.s.i.o.n.N.a.m.
│  000000d0: 6500 0000 0d00 6d00 6900 6e00 5300 6400  e.....m.i.n.S.d.
│  000000e0: 6b00 5600 6500 7200 7300 6900 6f00 6e00  k.V.e.r.s.i.o.n.
│  000000f0: 0000 1000 7400 6100 7200 6700 6500 7400  ....t.a.r.g.e.t.
│  00000100: 5300 6400 6b00 5600 6500 7200 7300 6900  S.d.k.V.e.r.s.i.
│ @@ -36,103 +36,103 @@
│  00000230: 6c00 6400 5600 6500 7200 7300 6900 6f00  l.d.V.e.r.s.i.o.
│  00000240: 6e00 4e00 6100 6d00 6500 0000 0800 6d00  n.N.a.m.e.....m.
│  00000250: 6100 6e00 6900 6600 6500 7300 7400 0000  a.n.i.f.e.s.t...
│  00000260: 1500 6f00 7200 6700 2e00 7300 7900 7300  ..o.r.g...s.y.s.
│  00000270: 7400 6500 6d00 6300 6100 6c00 6c00 2e00  t.e.m.c.a.l.l...
│  00000280: 7300 6300 6f00 7200 6500 7300 0000 0300  s.c.o.r.e.s.....
│  00000290: 3100 2e00 3100 0000 0200 3100 3700 0000  1...1.....1.7...
│ -000002a0: 0c00 3400 2e00 3200 2e00 3200 2d00 3500  ..4...2...2.-.5.
│ -000002b0: 3700 3600 3000 3200 3400 0000 0800 7500  7.6.0.2.4.....u.
│ -000002c0: 7300 6500 7300 2d00 7300 6400 6b00 0000  s.e.s.-.s.d.k...



More information about the Reproducible-builds mailing list