Bug#854670: diffoscope: autopkgtest failures

Iain Lane iain at orangesquash.org.uk
Thu Feb 9 18:07:01 UTC 2017


On Thu, Feb 09, 2017 at 05:45:35PM +0000, Iain Lane wrote:
> On Thu, Feb 09, 2017 at 11:52:50AM +0100, Mattia Rizzolo wrote:
> > E   ImportError: No module named 'debian'
> 
> Hmm, looks like skip_unless_module_exists() needs to catch the
> exception. Patch attached - I don't like the "skip" variable, so if you
> know of a nicer way (the function needs to return a callable so you
> can't use mark.skip AFAICS) then please do it.
> 
> The way I read the docs is that it should return None here; not sure why
> it doesn't - bug in python?

No, it says "If name is for a submodule (contains a dot), the parent
module is automatically imported."

But that means my patch is a bit wrong - try this version.

-- 
Iain Lane                                  [ iain at orangesquash.org.uk ]
Debian Developer                                   [ laney at debian.org ]
Ubuntu Developer                                   [ laney at ubuntu.com ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tests-Catch-ImportError-when-looking-to-see-if-a-mod.patch
Type: text/x-diff
Size: 1094 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20170209/e4cb663a/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20170209/e4cb663a/attachment.sig>


More information about the Reproducible-builds mailing list