[PATCH] reproducible Debian: Reverse Python 2.x dict order in the second build.

[Chris Lamb]

Mattia Rizzolo wrote:

> > > Umh, could you please set that variable in the pbuilderrc of the second
> > > build instead of using the hooks (which I don't understand how that
> > > would ever work
> > 
> > I just grepped for existing changes (eg. "I capture the environment"). If
> > these things don't work as you claim, please could you remove them so they
> > are not confusing?
> 
> I don't know, did that ever worked?

I assumed it did otherwise it would not be in the repo. I suggest removing
all of that code to prevent any further confusion...


> > -		write_page "<tr><td>env CAPTURE_ENVIRONMENT</td><td><em>not set</em></td><td>CAPTURE_ENVIRONMENT=\"I capture the environment\"</td></tr>"
> > +		write_page "<tr><td>env CAPTURE_ENVIRONMENT</td><td><em>not set</em></td><td>CAPTURE_ENVIRONMENT=\"I capture the environment\"<br />on amd64: PYTHONREVERSEDICTKEYORDER=1</td></tr>"
> 
> This would be everywhere, not just amd64.

Technically true, but I've only uploaded a python2.7 with my
PYTHONREVERSEDICTKEYORDER patch for amd64 so far. To save another patch
round, feel free to remove that bit before committing that you disagree;
I'm easy either way.

> Plus, I think it would look better if added a different line on the
> table, separated from CAPTURE_ENVIRONMENT.

Force-pushed as 899a13de to `export-PYTHONREVERSEDICTKEYORDER-pbuilderrc`.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-