Bug#850758: diffoscope: redundant undecoded AndroidManifest.xml (Binary XML) comparison in APK comparator

Chris Lamb lamby at debian.org
Mon Mar 6 22:01:44 UTC 2017

Maria Glukhova wrote:

> Thanks; Implemented in the attached patches.
> Would appreciate if someone reviewed that.

Looks good. My only gripes might be that:

* Tests don't test all the new code from a coverage point of view (eg.
  the MissingFile bits).

* You are introducing some easily-avoided long lines

Apart from that, feel free to commit; perhaps to the "experimental"


     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk

More information about the Reproducible-builds mailing list