Bug#866120: diffoscope: please add an xml comparator

[Chris Lamb]

tags 866120 + pending
thanks

Chris Lamb wrote:

> Woo, thanks! First, am going to merge this into the existing
> wishlist bug…

… And I've now also merged the code into our Git repo. Thanks!

I did make some changes after committing which might be useful
to know/understand for next time. First two (easy) style fixups
that should be fairly self-explanatory:

  https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=9d89fdda0101915eedf931a4c9127918cdfea79c

  https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=9123eb091c49db4d7685e36d33f539bcbecefae1

Next, I had to add MissingFile support to your comparator; did you run
the entire testsuite? *g*  In particular, the epub tests were failing
for me before I added:

  https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=2422e0f0f8a8ae66da0438f9fc64376faa154b53

Anyway, thank you again for your contribution. Let me know if you have
any questions on the above, but we all look forward to future patches
from yourself…


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb, Debian Project Leader
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-