Bug#866120: diffoscope: please add an xml comparator

[Juliana Rodrigues]

Hi Chris!

I see. I'll be more careful with python coding style
next time. (:

About the testsuite: Firstly I ran all tests, but some were naturally
failing (like test_debian, I guess). Then I focused on getting to work at
least the one test I was writting, since I don't know much about the
project yet.

Thank you very much for your support and for your quick fixes. I hope to be
able to contribute more in the future. :D

Juliana




Em sex, 21 de jul de 2017 06:48, Chris Lamb <lamby at debian.org> escreveu:

> tags 866120 + pending
> thanks
>
> Chris Lamb wrote:
>
> > Woo, thanks! First, am going to merge this into the existing
> > wishlist bug…
>
> … And I've now also merged the code into our Git repo. Thanks!
>
> I did make some changes after committing which might be useful
> to know/understand for next time. First two (easy) style fixups
> that should be fairly self-explanatory:
>
>
> https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=9d89fdda0101915eedf931a4c9127918cdfea79c
>
>
> https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=9123eb091c49db4d7685e36d33f539bcbecefae1
>
> Next, I had to add MissingFile support to your comparator; did you run
> the entire testsuite? *g*  In particular, the epub tests were failing
> for me before I added:
>
>
> https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=2422e0f0f8a8ae66da0438f9fc64376faa154b53
>
> Anyway, thank you again for your contribution. Let me know if you have
> any questions on the above, but we all look forward to future patches
> from yourself…
>
>
> Best wishes,
>
> --
>       ,''`.
>      : :'  :     Chris Lamb, Debian Project Leader
>      `. `'`      lamby at debian.org / chris-lamb.co.uk
>        `-
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20170721/ee3bddd6/attachment.html>