Bug#866120: diffoscope: please add an xml comparator

Chris Lamb lamby at debian.org
Mon Jul 24 20:54:24 UTC 2017


Hi Juliana,

> Just found out what was going wrong.
> 
> XMLFile returns an array with the Difference object, while the
> previous TextFile class doesn't. So test_apk was looking for a
> unified_diff in the wrong place.

Neat — looking forward to your patch! In fact, can you commit it
directly? :)

> This is easily fixed, but I've got a new question. Since XMLFile
> now returns an array, the presenter displays the difference for
> AndroidManifest file with two column pipes instead of one.
> (https://paste.debian.net/977967/)

I guess my first question would be whether other comparators that do
similar pretty-printing / decoding do the same thing, eg. JSON, etc.
etc.?


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-



More information about the Reproducible-builds mailing list