Bug#875451: diffoscope crashes when using --max-diff-block-lines

Hans-Christoph Steiner hans at eds.org
Mon Sep 11 13:50:00 UTC 2017


Package: diffoscope
Version: 85~bpo9+1

`fdroid verify` calls diffoscope like this:

diffoscope --max-report-size 12345678 \
           --max-diff-block-lines 100 \
           --html foo.html --text foo.txt \
           foo.apk another_foo.apk

And it has recently started to crash like this:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 396, in
 main
    sys.exit(run_diffoscope(parsed_args))
  File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 356, in
run_diffoscope
    Config().check_constraints()
  File "/usr/lib/python3/dist-packages/diffoscope/config.py", line 62,
in check_constraints
    self.check_ge("max_diff_block_lines", "max_page_diff_block_lines")
  File "/usr/lib/python3/dist-packages/diffoscope/config.py", line 59,
in check_ge
    raise ValueError("{0} ({1}) cannot be smaller than {2}
({3})".format(a, va, b, vb))
ValueError: max_diff_block_lines (100) cannot be smaller than
max_page_diff_block_lines (128)


Since we're not setting max_page_diff_block_lines, this should not crash.

.hc



More information about the Reproducible-builds mailing list