Bug#876901: QFINDTESTDATA uses __FILE__

[Pino Toscano]

In data martedì 14 novembre 2017 13:47:56 CET, Holger Levsen ha scritto:
> On Tue, Nov 14, 2017 at 07:22:07AM +0100, Pino Toscano wrote:
> > > There are quite a lot of packages that use __FILE__ so forgive me for
> > > not checking every single use-case of it.
> > 
> > This.  When something is used so widely, then changing its behaviour
> > blindly is simply a no-no.
> 
> I tend to agree.
> 
> > > This will require us to patch hundreds of packages, and isn't
> > > realistic.
> > 
> > If "hundreds of packages" misuse __FILE__, then simply *fix them*.
> > Sure, it will require time, energy, etc, but I do not see other ways
> > around that without breaking standard behaviours.
> 
> also agreed.
> 
> > > Please, you try sending hundreds of patches, then I will take your
> > > "solution" more seriously.
> > My *solution* (without quotes) is more realistic than your blind
> > breakage.
> 
> Pino, could you be so kind and repeat your proposed solution here again,
> for the sake of clarity?!

It is basically what I wrote in the quoted part above (not this one, the
last where you replied "also agreed".  I will repeat it again, as asked:

| No, the solution is:
| a) *not* break what __FILE__ means
| b) remove the misuses of __FILE__ in packages (not the case of
| QFINDTESTDATA)

As also Lisandro explained a bit more in another email, this solution
takes a bit more time and effort, but it pays off (especially if this
is done directly upstream) as all the improper usages will be removed,
with little to no effort specific for Debian.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20171114/46735299/attachment.sig>