Bug#879011: diffoscope: zipinfo diff shows warning differences that are due to temporary file names

[Ximin Luo]

Mike Hommey:
> On Thu, Oct 19, 2017 at 07:15:35PM +0900, Mike Hommey wrote:
>> Attached is my work in progress. I won't finish it right now because
>> it's getting late and I don't have all the optional tools to run the
>> test suite.
>>
>> It's worth noting that this changes the output, and the notable
>> difference is that the information whether files are stored or deflated
>> is lost. It doesn't seem at first glance that libarchive exposes that,
>> so that might be a showstopper :-/
> 
> Attached here is a full patchset that passes all zip-related tests. Please
> take a look at the changes in output, whether this is wanted or not.
> 

I've fixed it a different way:

https://anonscm.debian.org/cgit/reproducible/diffoscope.git/commit/?id=25fee28c8b29dbc66cd7bb57a2ab427651050c23

I didn't notice any slowdown that might have occurred due to the lack of random access to the file.

Let me know if this doesn't fix the original issue. I agree the stderr-to-stdout-when-tty is ridiculous. Funnily enough the behaviour isn't present when `-v` is enabled...

(I have applied 0001.patch since that's a separate issue, so thanks for that too.)

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git