Bug#863879: diffoscope: Optimize the common case of feeders.

Chris Lamb lamby at debian.org
Wed Jan 3 20:20:25 UTC 2018


tags 863879 + pending
thanks

Thanks for this, I've gone ahead and applied it here after making it
check against `None` explicitly rather than `False`-ness as this is
more idiomatic IMHO:

  https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=11370138e95176ba083bb0ad0876be7c5f4b568d

I did a quick and unreliable benchmark on two NetBSD images - it went
from 48.825s → 46.981s… so there is at least no regression :)

Thanks again :)


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-



More information about the Reproducible-builds mailing list