Bug#888401: diffoscope: report differences in filesystem extended attributes

[Chris Lamb]

Hey Niels,

> I am curious; the code seems like it implicitly rely on xattr.get_all
> returning keys in sorted/deterministic order to get a "non-noisy" diff,
> does xattr.get_all return values in a sorted/deterministic order?

When initially implementing this, I thought I saw a sorting call in
the pyxattr code. However, following the chain of:

  https://sources.debian.org/src/python-pyxattr/0.6.0-2/xattr.c/#L597
  |
  https://sources.debian.org/src/python-pyxattr/0.6.0-2/xattr.c/#L276
  |
  https://sources.debian.org/src/python-pyxattr/0.6.0-2/xattr.c/#L216
  |
  https://sources.debian.org/src/attr/1:2.4.47-2/man/man2/listxattr.2/#L99-L101

.. it's unordered. Fixed here:

  https://anonscm.debian.org/git/reproducible/diffoscope.git/commit/?id=5fcd71891aad9b7ed5195f490e7e42c3a12fa3d0

Thanks for the diligent review as usual!


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-