Bug#891867: diffoscope: improve .changes diffs

Chris Lamb lamby at debian.org
Thu Mar 1 21:46:29 UTC 2018


Mattia Rizzolo wrote:

> > > +                other.deb822.get_as_string('Checksums-Sha256') + "\n",
> > 
> > Why not .strip() them all instead, out of interest?
> 
> Because deb822.get_as_string() returns a single string containing all of
> 'Checksums-Sha256' (in this case) with the \n embedded in that string.

Ah, I see:

  '\n 75308f81588e44097465180b3572e3469d70c34fccd3ba14978d8a76d4036c7f 688 source_1.dsc\n ce8b1507e6cc936c6252 […]

[…]

> So to .str() them all [..]

Assuming you mean .strip() ..  Okay, why don't we .rstrip()? That would at
least normalise the suffix without screwing up the suffix? I'm probably
missing something :)


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-



More information about the Reproducible-builds mailing list