Bug#893183: diffoscope FTBFS with openjdk-9

[Adrian Bunk]

Source: diffoscope
Version: 91
Severity: serious

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope.html

...
_______________________________ test_diff_javap ________________________________

differences_javap = [<Difference javap -verbose -constants -s -l -private {} -- javap -verbose -constants -s -l -private {} []>]

    @skip_unless_tool_is_at_least('javap', javap_version, '1.8')
    def test_diff_javap(differences_javap):
>       diff(differences_javap, 'javap_class_expected_diff')

differences_javap = [<Difference javap -verbose -constants -s -l -private {} -- javap -verbose -constants -s -l -private {} []>]

tests/comparators/test_java.py:84: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

differences = [<Difference javap -verbose -constants -s -l -private {} -- javap -verbose -constants -s -l -private {} []>]
expected_diff_file = 'javap_class_expected_diff'

    def diff(differences, expected_diff_file):
        expected_diff = get_data(expected_diff_file)
>       assert differences[0].unified_diff == expected_diff
E       assert '@@ -34,13 +3..."Test.java"\n' == '@@ -31,13 +31..."Test.java"\n'
E         - @@ -34,13 +34,13 @@
E         ?      ^      ^
E         + @@ -31,13 +31,13 @@
E         ?      ^      ^
E                    line 1: 0
E            
E              public static int main(java.lang.String[]);
E                descriptor: ([Ljava/lang/String;)I
E         -      flags: (0x0009) ACC_PUBLIC, ACC_STATIC
E         ?            ---------
E         +      flags: ACC_PUBLIC, ACC_STATIC
E                Code:
E                  stack=1, locals=1, args_size=1
E           -         0: bipush        42
E           -         2: ireturn
E           +         0: iconst_m1
E           +         1: ireturn
E                  LineNumberTable:
E                    line 3: 0
E            }
E            SourceFile: "Test.java"

differences = [<Difference javap -verbose -constants -s -l -private {} -- javap -verbose -constants -s -l -private {} []>]
expected_diff = '@@ -31,13 +31,13 @@\n         line 1: 0\n \n   public static int main(java.lang.String[]);\n     descriptor: ([Ljava/...       0: iconst_m1\n+         1: ireturn\n       LineNumberTable:\n         line 3: 0\n }\n SourceFile: "Test.java"\n'
expected_diff_file = 'javap_class_expected_diff'

tests/comparators/test_java.py:66: AssertionError
------------------------------ Captured log setup ------------------------------
__init__.py                127 DEBUG    Loaded 65 comparator classes
specialize.py               40 DEBUG    Using ClassFile for /build/1st/diffoscope-91/.pybuild/cpython3_3.6/build/tests/data/Test1.class
specialize.py               40 DEBUG    Using ClassFile for /build/1st/diffoscope-91/.pybuild/cpython3_3.6/build/tests/data/Test2.class
command.py                  38 DEBUG    Executing javap -verbose -constants -s -l -private /build/1st/diffoscope-91/.pybuild/cpython3_3.6/build/tests/data/Test1.class
command.py                  38 DEBUG    Executing javap -verbose -constants -s -l -private /build/1st/diffoscope-91/.pybuild/cpython3_3.6/build/tests/data/Test2.class
diff.py                    177 DEBUG    Running diff -aU7 /tmp/tmpff97aoah_diffoscope/fifo1 /tmp/tmpff97aoah_diffoscope/fifo2
diff.py                    193 DEBUG    diff -aU7 /tmp/tmpff97aoah_diffoscope/fifo1 /tmp/tmpff97aoah_diffoscope/fifo2: returncode 1, parsed True
============== 2 failed, 364 passed, 18 skipped in 992.92 seconds ==============
E: pybuild pybuild:323: test: plugin distutils failed with: exit code=1: cd /build/1st/diffoscope-91/.pybuild/cpython3_3.6/build; python3.6 -m pytest -vv -r sxX -l --cov=diffoscope --cov-report=term-missing --cov-report=html
dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.6 returned exit code 13
make: *** [debian/rules:35: binary] Error 25