Bug#898022: diffoscope: Traceback when comparing paths with invalid unicode characters

Chris Lamb lamby at debian.org
Thu May 10 16:43:37 BST 2018


Hi Mattia,

> That's because argparse decodes the arguments

Ahh! Nice spot.

> Do you think this would be fine?

Whilst this works, would it not be better if we could use bytes for
filenames throughout? I mean, AIUI there is no assumption that
filesystems need to have any form of valid encoding whatsoever, let
alone UTF-8.

However, somewhat happy to see this in diffoscope as it certainly
improves the current state of affairs. If you do commit it, please
include my testcase (or something based on it) that I added in:

  https://bugs.debian.org/898022#5

  
Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-



More information about the Reproducible-builds mailing list