Bug#903447: diffoscope: AttributeError with node-module-deps/6.1.0-1

[Mattia Rizzolo]

On Tue, Jul 10, 2018 at 03:44:21PM +0200, Mattia Rizzolo wrote:
> On Tue, Jul 10, 2018 at 10:12:45AM +0200, Mattia Rizzolo wrote:
> > AttributeError: 'list' object has no attribute 'items'
> > 
> > 
> > I can totally reproduce this locally; artifacts will be available till
> > tomorrow
> 
> This is caused by the two attached very small .json:
> 
> mattia at warren ..cible/diffoscope/test/node-module-deps % diffoscope 1.json 2.json
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 460, in main
>     sys.exit(run_diffoscope(parsed_args))
>   File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 432, in run_diffoscope
>     difference = compare_root_paths(path1, path2)
>   File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 68, in compare_root_paths
>     difference = compare_files(file1, file2)
>   File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 118, in compare_files
>     return file1.compare(file2, source)
>   File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 366, in compare
>     difference = self._compare_using_details(other, source)
>   File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/file.py", line 304, in _compare_using_details
>     details.extend(self.compare_details(other, source))
>   File "/usr/lib/python3/dist-packages/diffoscope/comparators/json.py", line 73, in compare_details
>     diff = {repr(x): y for x, y in jsondiff.diff(a, b).items()}
> AttributeError: 'list' object has no attribute 'items'

Which for what I'm concerned is a jsondiff bug that I reported at
https://github.com/ZoomerAnalytics/jsondiff/issues/20

Nonetheless, I'd say to wrap the whole jsondiff stuff and catch all
possible exceptions (this would cover 903449 as well) and call it a day.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20180710/67d4cb27/attachment.sig>