Bug#904685: diffoscope: RuntimeError when trying to extract an encrypted file (.bmp)

[Ricardo Gaviria]

By the way, if this is a lower priority bug than others. I will gladly have
a look into the issue and try and resolve it, provided that we agree on the
expected behaviour of the tool under such a scenario.

Ricardo

On Fri, Jul 27, 2018 at 5:14 PM Ricardo Gaviria <ricardo at unitelabs.ch>
wrote:

> Hi Chris,
>
> Thanks for your response. Please find attached the culprit. I believe the
> issue may lie with the fact that I am trying to diff an archive which
> happens to be encrypted and requires a password.
>
> I'm guessing encrypted archives could be ignored when diff'ing and
> flagged, and possibly just diffing the fingerprint of the archive blob? Or
> what do you suggest?
>
> Thanks again,
> Ricardo
>
> On Fri, Jul 27, 2018 at 6:41 AM Chris Lamb <lamby at debian.org> wrote:
>
>> retitle 904685 diffoscope: RuntimeError when trying to extract an
>> encrypted file within .zip
>> tags 904685 + moreinfo
>> thanks
>>
>> Hi Ricardo,
>>
>> > Is this expected behaviour or is there a cmd line parameter which I
>> > could use to prevent this?
>>
>> Oh, not at all the expected behaviour. diffoscope should "never"
>> traceback on you.
>>
>> >   File "/usr/lib/python3.5/zipfile.py", line 1299, in open
>> >     "required for extraction" % name)
>> > RuntimeError: File acrobat.bmp is encrypted, password required for
>> > extraction
>>
>> Actually looks zipfile related. Could you reply, attaching the file in
>> question so we can debug & fix this?
>>
>>
>> Regards,
>>
>> --
>>       ,''`.
>>      : :'  :     Chris Lamb
>>      `. `'`      lamby at debian.org / chris-lamb.co.uk
>>        `-
>>
> --
> Regards,
> Ricardo Gaviria
> Software Engineer, UniteLabs
> *M: *+41 77 956 2376 <+41%2077%20956%2023%2076>
> *W: *http://unitelabs.ch
> *In: *https://www.linkedin.com/in/ricardogaviria/
>
> --
Regards,
Ricardo Gaviria
Software Engineer, UniteLabs
*M: *+41 77 956 2376
*W: *http://unitelabs.ch
*In: *https://www.linkedin.com/in/ricardogaviria/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20180727/0e60600f/attachment.html>