Bug#905885: diffoscope: skipping tests on ci.debian.net is perhaps wrong?

[Stuart Prescott]

> Braindumping here whilst I have a second...
> 
> > diffoscope recommends apktool but apktool is not currently in buster.
> 
>              ^^^^^^^^^^
> 
> Ah, this was the bit I was missing in my head. ie. not a Build-Depends :)

both, actually. diffoscope FTBFS in buster because:

Build-Depends: apktool <!nocheck>, …

(which is an RC bug waiting to be filed)

*also* diffoscope recommends apktool but tests on ci.d.n do not fail (but 
should, I think)

> > Perhaps @tool_required could be extended with an "all tools required"
> > mode such that no tests are skipped or missing tools are a test failure
> > (or error). An environment variable would work for setting that mode
> > and that mode used at package build time and in autopkgtest.
> 
> Out of curiousity, is there an environment variable that ci.debian.net
> reliably exports?

You'd set that environment variable in d/rules and d/tests/* (and so could 
other distros who want to test that packages are working)

> (One difficulty with "just" extending @tool_required is that sometimes
> we really do want to skip the tests as they require a newer/older
> version of a particular tool in order that we can correctly match up
> the output.)

If the newer/older version doesn't work, surely the test should fail?

cheers
Stuart

-- 
Stuart Prescott    http://www.nanonanonano.net/   stuart at nanonanonano.net
Debian Developer   http://www.debian.org/         stuart at debian.org
GPG fingerprint    90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7