Bug#908072: diffoscope: `bin/diffoscope --list-debian-substvars` output depends on installed packages

[Chris Lamb]

tags 908072 + pending
thanks

Fixed in Git, pending upload:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/889e4bf7394d465ae2c9a17a0661bb401c30f54a

  diffoscope/main.py | 15 ++++++++++++---
  1 file changed, 12 insertions(+), 3 deletions(-)

I didn't go with the:

    - import rpm
    + try:
    +    import rpm
    + except ImportError:
    +    tool_required.all.add('rpm2cpio') # lol hack
    + raise

… solution as, for example, we were not importing changes.py (and thus
calling @tool_required('gpg')) but this was only due to not importing
the enhanced Debian comparator in debian.py so this would have been
somewhat too distant of an action.

This solution also allows for a big stonkin' comment regarding this
ugliness.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-