Bug#908900: diffoscope: tests fail with colord 1.4.3

Chris Lamb lamby at debian.org
Sat Sep 15 18:03:27 BST 2018


Package: diffoscope
Version: 101
Severity: important

Since the upload of colord 1.4.3, the diffoscope testsuite fails with:


  =================================== FAILURES ===================================
  __________________________________ test_diff ___________________________________
  
  differences = [<Difference cd-iccdump {} -- cd-iccdump {} []>]
  
      @skip_unless_tools_exist('cd-iccdump')
      def test_diff(differences):
          if 'ne_SU' in differences[0].unified_diff:
              pytest.skip("Endian-specific differences detected; see "
                          "<https://bugs.debian.org/847595>")
      
          expected_diff = get_data('icc_expected_diff')
  >       assert differences[0].unified_diff == expected_diff
  E       AssertionError: assert '@@ -1,20 +1,...4 bytes]\n \n' == '@@ -1,20 +1,2... [24 bytes]\n'
  E           @@ -1,20 +1,20 @@
  E            icc:
  E            Header:
  E              Size		= 14684 bytes
  E              Version	= 4.3
  E              Profile Kind	= display-device
  E              Colorspace	= rgb
  E              Conn. Space	= xyz
  E           -  Date, Time	= 2016-02-15, 21:02:09
  E           +  Date, Time	= 2016-02-15, 21:03:22
  E              Flags		= Not embedded profile, Use anywhere
  E              Dev. Attrbts	= reflective, glossy
  E              Rndrng Intnt	= perceptual
  E              Creator	= lcms
  E         - -  Profile ID	= 0477fa4bb5ae5ae9a778f5cd72eb45a4
  E         - +  Profile ID	= 06017f17ec507191e9d859f2324fca53
  E         + -  Profile ID	= 0x0477fa4b
  E         + +  Profile ID	= 0x06017f17
  E         +  
  E            tag 00:
  E              sig	'desc' [0x64657363]
  E              size	38
  E              type	'mluc' [0x6d6c7563]
  E            Text:
  E              en_US:	sRGB [24 bytes]
  E         -
  

We would normally:

 1. Update the expected diff for this latest version.

 2. Add a minimum version check directive for pytest.

However, the `cd-iccdump` command has no --version command and, whilst
the `colord` binary does, it relies on the daemon running to return any
output.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-



More information about the Reproducible-builds mailing list