Bug#909122: diffoscope: MemoryError when comparing big ISO images

[Chris Lamb]

Hi Marek,

> The whole thing could be avoided if earlier check (if initial 10 chars
> contains '[' or '{') would be executed not only on "text" files.

Indeed. The origins of this appear to be:

  https://salsa.debian.org/reproducible-builds/diffoscope/commit/2a758d3d0205e934ed6dffebb5d6462b00fe590d

> I can provide a patch for either option, but I'd like to know which one
> of them you prefer.

I'm not quite sure but I would probably go with dropping the whole
`is_text` thing but keeping everything the same. Are you happy and
comfortable creating an MR for this? Thanks in advance…

> Obviously ISO file is not JSON.

♥


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org / chris-lamb.co.uk
       `-