Bug#900918: debian-installer: Please make the generated images reproducible
lamby at debian.org
Sat Jan 19 12:34:20 GMT 2019
[Keeping Kibi in CC as requested off-list, dropping mtools at p.d.o]
First, thank you so much for your review. I believe I have resolve
all of your issues on the corresponding merge request, as well as
rebasing it against the current master:
> * 0c19a29645a6a3136f3a51da5d5cf1cfcec5fdfb mentions file system
> ordering only, but that's just the sort part
I've split this commit and it is much clearer now.
> * 71391967763708055a65ed68999db8f4ea6fc6e6 sets “deb00001” as the FAT
> volume ID; have you checked with people like debian-cd@ whether
> another constant might make more sense?
Clarified where this comes from in the commmit and in the code
> * 7c533fa721c3ae89ca81d1336b5928a80ed0d531 thanks for the clarity
> [ also: “becuase” in commit message. ]
> * c35b8688696b1b4563a45d0feeabc3a0c0f2eccb “determinstic”
> * ea1a896181daa3b82c5a62ae31839b457a0dbe0b modifies BUILD_DATE, adding
> a few characters (“:SS”); that ends up in various help screens
In my tests, this did not break any visual text wrapping, etc.
> * f181b4fe90b9030f515c7e6129239b96131b3926 oh more en_GB, yay.
Fixed (use 'results' instead).
Thank you again for your review. Let me know if you would require
any further modifications before merging. :-)
: :' : Chris Lamb
`. `'` lamby at debian.org 🍥 chris-lamb.co.uk
More information about the Reproducible-builds