Bug#931709: diffoscope: testsuite failure on all archs

[Gianfranco Costamagna]

Source: diffoscope
Version: 116
Severity: serious
Justification: autopkgtests failures are RC since bullseye
Tags: patch

Hello, you have an autopkgtest failure on sid for version 116, due to missing tools at runtime.

While we are at it, there are a few tools that aren't available everywhere, due to different architectures, so I crafted a patch
that should make hopefully testsuite pass everywhere.

diff -Nru diffoscope-116/debian/tests/pytest diffoscope-116ubuntu1/debian/tests/pytest
--- diffoscope-116/debian/tests/pytest  2019-07-07 16:54:29.000000000 +0200
+++ diffoscope-116ubuntu1/debian/tests/pytest   2019-07-09 08:46:17.000000000 +0200
@@ -10,7 +10,7 @@
 export LIBGUESTFS_MEMSIZE=128
 if [ "$(basename "$0")" = "pytest-with-recommends" ]; then
     export DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS=1
-    export DIFFOSCOPE_TESTS_MISSING_TOOLS="cbfstool otool lipo wasm2wat"
+    export DIFFOSCOPE_TESTS_MISSING_TOOLS="apktool zipinfo pedump oggDump ppudump cbfstool otool lipo wasm2wat"
 fi

 cp -r tests "$ADTTMP"

--- diffoscope-116/debian/tests/control.in      2019-07-07 16:54:29.000000000 +0200
+++ diffoscope-116ubuntu1/debian/tests/control.in       2019-07-09 08:46:17.000000000 +0200
@@ -7,7 +7,7 @@
 Depends: diffoscope, black, python3-pytest, file, linux-image-amd64 [amd64] | linux-image-generic [amd64], %RECOMMENDS%, %PYRECOMMENDS%

 Tests: pytest
-Depends: diffoscope, python3-pytest, file
+Depends: diffoscope, python3-pytest, file, python3-tlsh

 Tests: basic-command-line
 Depends: diffoscope


please accept if possible this patch.

NB some tools such as pedump should be available everywhere, but mono is explictly disabling it on arm64...
I'm doing a test build enabling it to see what happens

https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+build/17243705

thanks

Gianfranco