Bug#931881: diffoscope: undeclared versioned dependency on file

[Steve Langasek]

Package: diffoscope
Version: 117
Severity: serious
Justification: autopkgtest failures and runtime failures
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu eoan

Dear maintainers,

diffoscope 117 is not migratable to testing because its autopkgtests are
failing, due to runtime errors complaining about a wrong version of the
'file' command:

[...]
=================================== FAILURES ===================================
_________________________ test_text_proper_indentation _________________________

args2 = (), kwargs2 = {}

    def inner(*args2, **kwargs2):
        if args[0]:  # i.e. the condition of the skipif() is True
>           return pytest.fail(msg)
E           Failed: requires file >= 5.37 (5.35 detected) (DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS=1)

args       = (True,)
args2      = ()
kwargs2    = {}
msg        = ('requires file >= 5.37 (5.35 detected) '
 '(DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS=1)')

tests/utils/tools.py:77: Failed
[...]

    (https://ci.debian.net/packages/d/diffoscope/testing/amd64/)

file 5.37 is only present in Debian experimental, and the diffoscope package
declares no dependency on file >= 5.37.

At the very least, it seems this should be a versioned test dep on file (>=
5.37), but perhaps it should also be a versioned runtime dependency.  I
haven't looked to see what the impact is of the wrong version of 'file' when
DIFFOSCOPE_TESTS_FAIL_ON_MISSING_TOOLS is not set.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20190711/fe143e73/attachment.sig>