Bug#931881: diffoscope: undeclared versioned dependency on file

[Chris Lamb]

Hi Mattia,

> >  I think we need to add "file" to the DIFFOSCOPE_TESTS_MISSING_TOOLS
> >  list in debian/tests/pytest. Mattia, can you confirm?
[…]
> mh, no. I think some logic needs tweaking, as file is definitely 
> present (it's an hard dependency of diffoscope), and that test should 
> just be skipped.

I just went to hack on this but, hmm, isn't this providing exactly
what we need? :) ie. skipping these tests when run with a insufficiently
new version of file?

My testcase is to run:

  $ py.test-3 -rsx tests/test_presenters.py::test_text_proper_indentation

… within current sid (ie. src:file 5.35-4) and then by variously exporting:

  * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS=[unset]
    → Skipped correctly.

  * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS=''
    → Fails; the required version is missing and unlisted.

  * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS="foo bar" 
    → Fails; the required version is missing and unlisted.

  * DIFFOSCOPE_FAIL_TESTS_ON_MISSING_TOOLS="foo bar file"
    → Skipped correctly.

What am I missing here? :) (Note that I renamed this variable in
d5b9daf04).


Best wishes,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org 🍥 chris-lamb.co.uk
       `-