Bug#934405: debhelper: Please ignore binNMUs in get_source_date_epoch() function

[Dmitry Shachnev]

Hi all,

On Mon, Aug 12, 2019 at 06:53:01PM +0200, Mattia Rizzolo wrote:
> On Mon, Aug 12, 2019 at 03:48:06PM +0000, Holger Levsen wrote:
> > > I think it would be nice if that function ignored binNMU changelog entries.
> >
> > nope, please dont. using changelog entries inconsistently is a recipe
> > for desaster.
>
> Same.
>
> My notes from IRC, so they can last longer:
> 
> [09:08:42 PM] <nthykier> comments on #934405 is welcome
> [09:08:45 PM] -zwiebelbot- Debian#934405: debhelper: Please ignore binNMUs
> in get_source_date_epoch() function - https://bugs.debian.org/934405
> [10:53:13 PM] <mapreri> nthykier: well, we used to do that in the past, i.e.
> using the previous changelog date.  But we switched away because it was also
> causing problems: #843773
> [10:53:18 PM] -zwiebelbot- Debian#843773: sbuild should use build date as
> binnmu changelog date - https://bugs.debian.org/843773
> [10:53:45 PM] <mapreri> nthykier: I fear that having debhelper's
> get_source_date_epoch() do that, would still lead to the same situation it
> was in the past, leading to that same bug once again, just via a different
> route.

OK, fair enough — using the previous changelog entry has its downsides.

For now I have just disabled normalizing PNGs in qtbase-opensource-src.

Feel free to close this bug as wontfix.

> [10:55:06 PM] <mapreri> If I have to express my opinion on this matter,
> it's a clear case on why keeping the timestamps within file metadata of
> generated files is mostly a horrible idea and should be removed, instead of
> normalized.

+1.

--
Dmitry Shachnev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20190813/8dfd3d51/attachment.sig>