Bug#968124: diffoscope: FTBFS with fpc 3.2.0

[Graham Inggs]

Source: diffoscope
Version: 155
Severity: serious
Tags: ftbfs sid
X-Debbugs-CC: pkg-pascal-devel at alioth-lists.debian.net

Hi Maintainer

As can be seen on reproducible builds [1], this package FTBFS since
the upload of fpc 3.2.0+dfsg-5 to unstable.

I've copied what I hope is the relevant part of the log below.

Regards
Graham


[1] https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope.html


=================================== FAILURES ===================================
_____________________________ test_identification ______________________________

file1 = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>

    @skip_unless_tools_exist("ppudump")
    def test_identification(file1):
>       assert isinstance(file1, PpuFile)
E       AssertionError: assert False
E        +  where False = isinstance(<<class
'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>,
PpuFile)

file1      = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>

tests/comparators/test_ppu.py:51: AssertionError
__________________________________ test_diff ___________________________________

differences = []

    @skip_unless_tool_is_at_least("ppudump", ppudump_version, "3.0.0")
    def test_diff(differences):
        expected_diff = get_data("ppu_expected_diff")
>       assert differences[0].unified_diff == expected_diff
E       IndexError: list index out of range

differences = []
expected_diff = ('@@ -15,15 +15,15 @@\n'
 ' Definitions stored      : 121\n'
 ' Symbols stored          : 398\n'
 ' \n'
 ' Interface section\n'
 ' ------------------\n'
 ' Module Name: CastleGenericLists\n'
 ' \n'
 '-Source file 1 : castlegenericlists.pas 2016/02/17 15:03:46\n'
 '+Source file 1 : castlegenericlists.pas 2016/02/17 15:04:53\n'
 ' Uses unit: System (Crc: 09C1FD4E, IntfcCrc: 3A093E2F, IndCrc: FEDD6E0A)\n'
 ' Uses unit: objpas (Crc: 663BC437, IntfcCrc: CA7886A2, IndCrc: 64D020AC)\n'
 ' Uses unit: fgl (Crc: C38E0A5A, IntfcCrc: 470D2834, IndCrc: 0764D076)\n'
 ' Link unit object file: castlegenericlists.o (static )\n'
 ' DerefMapsize: 2\n'
 ' DerefMap[0] = FGL\n'
 ' DerefMap[1] = SYSTEM\n')

tests/comparators/test_ppu.py:67: IndexError
__________________________ test_compare_non_existing ___________________________

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f1522be2520>
file1 = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>

    @skip_unless_tool_is_at_least("ppudump", ppudump_version, "3.0.0")
    def test_compare_non_existing(monkeypatch, file1):
>       assert_non_existing(monkeypatch, file1, has_null_source=False)

file1      = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f1522be2520>

tests/comparators/test_ppu.py:72:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f1522be2520>
fixture = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>
has_null_source = False, has_details = True

    def assert_non_existing(
        monkeypatch, fixture, has_null_source=True, has_details=True
    ):
        monkeypatch.setattr(Config(), "new_file", True)
        assert Config().new_file, "Did not get patched"

        difference = fixture.compare(MissingFile("/nonexisting", fixture))

        assert difference.source2 == "/nonexisting"
>       assert not has_details or len(difference.details) > 0
E       AssertionError

difference = <Difference
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu
-- /nonexisting []>
fixture    = <<class 'diffoscope.comparators.binary.FilesystemFile'>
/build/1st/diffoscope-155/.pybuild/cpython3_3.8/build/tests/data/test1.ppu>
has_details = True
has_null_source = False
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f1522be2520>

tests/utils/nonexisting.py:35: AssertionError