Bug#980356: dh-strip-nondeterminism: Should not bail out on read-only files

[Axel Beckert]

Package: dh-strip-nondeterminism
Version: 1.9.0-1
Severity: wishlist

Hi,

working on packages not updated for quite a while, I did the following
changes to libcgi-github-webhook-perl:

* Bump debhelper from 9 to 13.
* Set "Rules-Requires-Root: no".

This caused a FTBFS because dh_strip_nondeterminism failed to strip
non-determinism from files installed with mode 444:

[…]
   dh_strip_nondeterminism
dh_strip_nondeterminism: error: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/errored.png: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/errored.png: unable to overwrite: copy_data: Permission denied at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 78.

dh_strip_nondeterminism: error: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/failed.png: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/failed.png: unable to overwrite: copy_data: Permission denied at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 78.

dh_strip_nondeterminism: error: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/success.png: debian/libcgi-github-webhook-perl/usr/share/perl5/auto/share/module/CGI-Github-Webhook/success.png: unable to overwrite: copy_data: Permission denied at /usr/share/perl5/File/StripNondeterminism/handlers/png.pm line 78.

dh_strip_nondeterminism: error: Aborting due to earlier error
[…]

The files in question were installed by the build system (probably
caused by libdist-zilla-perl's Dist::Zilla::Plugin::ModuleShareDirs) as
follows:

-r--r--r-- 1 abe abe 1629 Jan 18 05:22 errored.png
-r--r--r-- 1 abe abe  756 Jan 18 05:22 errored.svg
-r--r--r-- 1 abe abe 1645 Jan 18 05:22 failed.png
-r--r--r-- 1 abe abe  754 Jan 18 05:22 failed.svg
-r--r--r-- 1 abe abe 1672 Jan 18 05:22 success.png
-r--r--r-- 1 abe abe  749 Jan 18 05:22 success.svg

My workaround so far is this in debian/rules:

override_dh_strip_nondeterminism:
	find debian/libcgi-github-webhook-perl -perm 444 | xargs chmod -c 644
	dh_strip_nondeterminism

But IMHO this shouldn't be necessary.

How to reproduce:

Use a git checkout of https://github.com/xtaran/CGI-Github-Webhook and
comment out that "find" line in debian/rules.

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'unstable-debug'), (500, 'buildd-unstable'), (110, 'experimental'), (1, 'experimental-debug'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-1-amd64 (SMP w/4 CPU threads)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
LSM: AppArmor: enabled

Versions of packages dh-strip-nondeterminism depends on:
ii  libdebhelper-perl                 13.3.1
ii  libfile-stripnondeterminism-perl  1.9.0-1
ii  perl                              5.32.0-6

dh-strip-nondeterminism recommends no packages.

dh-strip-nondeterminism suggests no packages.

-- no debconf information