Bug#980356: dh-strip-nondeterminism: Should not bail out on read-only files

[Axel Beckert]

Hi Chris,

Chris Lamb wrote:
> > My workaround so far is this in debian/rules:
> >
> > override_dh_strip_nondeterminism:
> > 	find debian/libcgi-github-webhook-perl -perm 444 | xargs chmod -c 644
> > 	dh_strip_nondeterminism
> >
> > But IMHO this shouldn't be necessary.
> 
> Agreed, and thanks for the report plus the steps on how to easily
> reproduce. I'm uploading strip-nondeterminism 1.10.0 very shortly that
> prints the following when run against your package with the "find"
> line removed.
> 
>      dh_link
>      dh_strip_nondeterminism
>   dh_strip_nondeterminism: warning: Ignoring unwritable file: errored.png
>   dh_strip_nondeterminism: warning: Ignoring unwritable file: failed.png
>   dh_strip_nondeterminism: warning: Ignoring unwritable file: success.png
>      dh_compress
>      dh_fixperms

Hmmm, ok, that was not the solution I expected, but is indeed a very
unintrusive solution.

I kinda expected that it kinda forces an optimization as it obviously
does when running under root.

Then again, it's just a kind of optimization. If that one is no more
done and the RB buildds show a regression, it's at least clear where
it comes from.

So thanks for the unexpectedly prompt fix! :-)

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE