Bug#988964: please demote diffoscope to Recommends

[Vagrant Cascadian]

On 2021-05-21, Vagrant Cascadian wrote:
> On 2021-05-21, John Scott wrote:
>> On my system, reprotest has the following Depends/Recommends:
>> Depends: diffoscope (>= 112~), python3-distro, python3-rstr, python3:any, python3-debian, apt-utils, libdpkg-perl, procps, python3-pkg-resources
>> Recommends: disorderfs, faketime, locales-all, sudo
>>
>> Reprotest should really recommend Diffoscope so that users don't need
>> to install it whom only want to check if packages are reproducible;
>> this is what the --no-diffoscope argument is for.
>>
>> I would send a Merge Request, but I frankly can't figure out where this
>> comes from. The applicable section in debian/control says
>> Depends: ${python3:Depends},
>>  python3-debian,
>>  apt-utils,
>>  libdpkg-perl,
>>  procps,
>>  python3-pkg-resources,
>>  python3-rstr,
>>  ${misc:Depends}
>> Recommends:
>>  diffoscope (>= 112~),
>>  disorderfs,
>>  faketime,
>>  locales-all,
>>  sudo,
>>
>> so my only guess is that Diffoscope gets pulled into
>> ${python3:Depends}?
>
> Yes, just confirmed that it gets added through python3:Depends.
>
> So, I presume it will require mangling python3:Depends, or adjusting the
> code to convince the pybuild/dh_python/etc that it doesn't belong there.

diffoscope is in install_requires, removing it gets it out of
python3:Depends, but may have other unintended consequences:

diff --git a/setup.py b/setup.py
index 72c2c00..d04d554 100644
--- a/setup.py
+++ b/setup.py
@@ -20,7 +20,6 @@ setup(name='reprotest',
               ],
           },
       install_requires=[
-          'diffoscope',
           'rstr',
           'distro',
           ],


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20210521/707bafb7/attachment.sig>