Bug#1002678: FTBFS with OCaml 4.13.1

[Chris Lamb]

Hi Stéphane,

> Your package FTBFS with OCaml 4.13.1 with the following error:
>> XFAIL tests/comparators/test_apk.py::test_android_manifest
   ^

This is actually an "eXpected failure" and not the root cause of the
build failure we are seeing. I think you just chose the wrong snippet
of the log to quote. *shrugs*

No matter, and this is actually reassuring for me: after all, what does
OCaml have to do with Android manifests? :)  Anyway, looking at the full
log [0] the actual failing test is as follows:


    =================================== FAILURES ===================================
    __________________________________ test_diff ___________________________________

    differences = [<Difference ocamlobjinfo -- ocamlobjinfo []>]

        @skip_unless_tool_is_at_least("ocamlobjinfo", ocaml_version, "4.12")
        def test_diff(differences):
    >       assert_diff(differences[0], "ocaml_expected_diff")

    differences = [<Difference ocamlobjinfo -- ocamlobjinfo []>]

    tests/comparators/test_ocaml.py:77: 
    _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

    difference = <Difference ocamlobjinfo -- ocamlobjinfo []>
    filename = 'ocaml_expected_diff'

        def assert_diff(difference, filename):
            # Assign seen and expected values to local variables to improve contextual
            # information in failed tests.
            seen = difference.unified_diff
            expected = get_data(filename)
    >       assert seen == expected
    E       AssertionError

    difference = <Difference ocamlobjinfo -- ocamlobjinfo []>
    expected   = ('@@ -1,5 +1,5 @@\n'
     '-Unit name: Test1\n'
     '+Unit name: Test2\n'
     ' Interfaces imported:\n'
     '-\t69a7449a2ee894ef85f1a4d8645e8051\tTest1\n'
     '+\t187969740b6c403b926a8d81613601ae\tTest2\n'
     ' \t4b04b4eda19aa722df365141895fb347\tStdlib\n'
     ' \tb6c6694955e10001aed267571104a961\tCamlinternalFormatBasics\n')
    filename   = 'ocaml_expected_diff'
    seen       = ('@@ -1,5 +1,5 @@\n'
     '-Unit name: Test1\n'
     '+Unit name: Test2\n'
     ' Interfaces imported:\n'
     '-\t605070d38b135b920997a99ca17b8a60\tTest1\n'
     '+\t930b7a610c2f7452a7e77b08ef005d36\tTest2\n'
     ' \t2d082666be7fc2ba916e7233397491df\tStdlib\n'
     ' \tc4b583a727ec28f5bc9ba36adc64cfc7\tCamlinternalFormatBasics\n')


Okay. I will upload a version of diffoscope before the weekend that will
build successfully with both the version in unstable (currently
4.11.1) and this new proposed version (4.13.1).

Thanks for the bug report.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby at debian.org 🍥 chris-lamb.co.uk
       `-