Salsa reprotest CI not picky enough? (Was: Bug#1026877: opari2: please make the build reproducible)

[Vagrant Cascadian]

On 2022-12-24, Samuel Thibault wrote:
> Chris Lamb, le ven. 23 déc. 2022 05:32:47 +0000, a ecrit:
>> Whilst working on the Reproducible Builds effort [0] we noticed that
>> opari2 could not be built reproducibly.
>> 
>> Patch attached that exports CFLAGS from dpkg-buildflags(1), ensuring
>> that -fdebug-prefix-map (and similar) to the underlying build system.
>
> I'm wondering how it is that the salsa reprotest CI didn't catch it:
>
> https://salsa.debian.org/debian/opari2/-/jobs/3675809
>
> Is there some salsa-ci option that I should enable to make it more
> picky?

  https://salsa.debian.org/debian/opari2/-/jobs/3696823#L1036

  INFO:reprotest:build "experiment-1": FIX environment, FIX build_path, ...

Something is telling reprotest to not vary build paths. I also see weird
things suggesting the standard build path reprotest uses is duplicated:

  https://salsa.debian.org/debian/opari2/-/jobs/3696823#L473

  make[1]: Entering directory '/tmp/reprotest.57Bwiu/const_build_path/const_build_path'

Normally, there would just be a single "const_build_path" subdir. I
noticed this issue on one of the packages I maintain, but haven't poked
at it yet.

This suggests to me the salsa-ci reprotest jobs are somehow manually
adjusting the build paths in some way above-and-beyond how reprotest
normally varies the build path? We probably should follow-up with the
salsa-ci folks...


The example for the salsa-ci suggests that build paths variations are
enabled by default under the "Adding extra arguments to reprotest":

  https://salsa.debian.org/salsa-ci-team/pipeline/-/tree/master#adding-extra-arguments-to-reprotest

  variables:
    SALSA_CI_REPROTEST_ARGS: --variations=-build_path

You could try inverting it, and passing --variations=+build_path


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20221223/f11b59de/attachment.sig>