Bug#1035645: reprotest: FTBFS with tox 4

[Vagrant Cascadian]

Control: tags 1035645 patch

On 2023-05-06, Stefano Rivera wrote:
> Log snippet:
> dh_auto_test -- --test-tox
> I: pybuild base:240: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.11_reprotest/build; tox -c /<<PKG
> BUILDDIR>>/tox.ini --sitepackages -e py311
> py311: failed with pass_env values cannot contain whitespace, use comma to have multiple value
> s in a single line, invalid values found 'REPROTEST_TEST_* VIRTUALENV_DOWNLOAD *_proxy TERM'
>   py311: FAIL code 1 (0.00 seconds)
>   evaluation failed :( (0.06 seconds)
> E: pybuild pybuild:388: test: plugin distutils failed with: exit code=1: cd /<<PKGBUILDDIR>>/.
> pybuild/cpython3_3.11_reprotest/build; tox -c /<<PKGBUILDDIR>>/tox.ini --sitepackages -e py311
> dh_auto_test: error: pybuild --test --test-tox -i python{version} -p 3.11 --test-tox returned exit code 13

This patch is trivial and fixes building with tox 4, but unfortunately
breaks building with tox 3:

From 8ee881b36a3578e652cc1693fd047692b1fa3fa9 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant at debian.org>
Date: Sat, 6 May 2023 16:48:39 -0700
Subject: [PATCH] tox.ini: Fix build with tox 4 by using comma-separated
 values. (Closes: #1035645)

---
 tox.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tox.ini b/tox.ini
index 1c3488d..0e76251 100644
--- a/tox.ini
+++ b/tox.ini
@@ -10,7 +10,7 @@ commands =
   {envpython} -m coverage html
 
 [testenv]
-passenv = REPROTEST_TEST_* VIRTUALENV_DOWNLOAD *_proxy TERM
+passenv = REPROTEST_TEST_*,VIRTUALENV_DOWNLOAD,*_proxy,TERM
 # usedevelop = True
 deps =
   coverage
-- 
2.39.2


I am not terribly familiar with tox; is it plausible to create a patch
that works with both of them? Maybe a conditional in tox.ini?


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/reproducible-builds/attachments/20230506/c8a7d6e3/attachment.sig>