Bug#1093412: Regression in tests with new faketime

[Ian Jackson]

Control: reassign -1 fakeroot
Control: found -1 debian/0.9.10+2024-06-05+gba9ed5b2-0.1
Control: fixed -1 debian/0.9.10+2024-06-05+gba9ed5b2-0.2

James Addison writes ("Re: Bug#1093412: Regression in tests with new faketime"):
> Although we want reprotest to intentionally vary[1] the apparent
> system clock -- to help discover unwanted dynamic timestamps that
> appear in the resulting output -- we do not want it to affect
> filesystem timestamps, because those may represent authorship and/or
> versioning information.  In some cases I think filesystem timestamps
> can also affect build processes - e.g. Make target evaluation - but
> I'm not sure that that is our primary concern.
> 
> By default, faketime does adjust apparent filesystem timestamps -- and
> so we use the NO_FAKE_STAT option[2] to deactivate that behaviour.

That makes sense to me.

I see that the reprotest autopkgtest is now fixed, after I restored
the default to not fake utime.

There is still a problem with the gem2deb autopkgtests which looks
like UB.  I found some UB (#1093599) and am intending to fix it.

Thanks for your input!

Ian.

-- 
Ian Jackson <ijackson at chiark.greenend.org.uk>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.