Bug#1120043: reprotest: --no-clean-on-error does not work

[Yavor Doganov]

Package: reprotest
Version: 0.7.32
Severity: normal

   * What led up to the situation?

I tried to examine a strange reprotest error and I needed the build
trees from both builds, not just the .debs and the diffoscope output.

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

I launched reprotest from the topsrcdir of the package I wanted to test:

  $ reprotest --store-dir /home/yavor/repro --no-clean-on-error .

   * What was the outcome of this action?

reprotest exited with an error but the directory in /tmp was wiped out
so I couldn't inspect it.

   * What outcome did you expect instead?

I was expecting reprotest to leave both build trees in /tmp for further
inspection, under the subdirectory it created.

-- System Information:
Debian Release: forky/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, x32

Kernel: Linux 6.17.6+deb14-amd64 (SMP w/6 CPU threads; PREEMPT)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), LANGUAGE=bg:ru:mk
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages reprotest depends on:
ii  apt-utils       3.1.11
ii  libdpkg-perl    1.22.21
ii  procps          2:4.0.4-9
ii  python3         3.13.7-1
ii  python3-debian  1.0.1
ii  python3-distro  1.9.0-1
ii  python3-rstr    3.2.2-1

Versions of packages reprotest recommends:
ii  diffoscope-minimal  307
ii  disorderfs          0.6.0-1
ii  faketime            0.9.10+2024-06-05+gba9ed5b2-0.6
ii  locales-all         2.41-12
ii  sudo                1.9.17p2-1

Versions of packages reprotest suggests:
ii  autodep8     0.30
pn  qemu-system  <none>
ii  qemu-utils   1:10.1.2+ds-1
ii  schroot      1.6.13-7

-- no debconf information