<div dir="ltr"><div><div><div>Chris,<br></div><div><br>I see. Seems like file ordering differs for some reason. I should not have relied on it, anyway.<br></div>Rewrote it so file ordering is not taken into account. Does it work now?<br><br></div>Thank you,<br></div>Maria<br><div><div><div><div><br><div class="gmail_quote"><div dir="ltr">вс, 15 янв. 2017 г. в 2:43, Chris Lamb <<a href="mailto:lamby@debian.org">lamby@debian.org</a>>:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Maria,<br class="gmail_msg">
<br class="gmail_msg">
Thank you so much for these :)<br class="gmail_msg">
<br class="gmail_msg">
> Added some tests for APK comparator, see attached patch.<br class="gmail_msg">
<br class="gmail_msg">
Unfortunately I'm seeing:<br class="gmail_msg">
<br class="gmail_msg">
differences = [<Difference zipinfo {} -- zipinfo {} []>, <Difference APK metadata -- APK metadata []>, <Difference AndroidManifest.xml -- AndroidManifest.xml []>, <Difference original/AndroidManifest.xml -- original/AndroidManifest.xml []>]<br class="gmail_msg">
<br class="gmail_msg">
@skip_unless_tools_exist('apktool', 'zipinfo')<br class="gmail_msg">
def test_android_manifest(differences):<br class="gmail_msg">
> assert differences[1].source1 == 'AndroidManifest.xml'<br class="gmail_msg">
E assert 'APK metadata' == 'AndroidManifest.xml'<br class="gmail_msg">
E - APK metadata<br class="gmail_msg">
E + AndroidManifest.xml<br class="gmail_msg">
<br class="gmail_msg">
Any ideas?<br class="gmail_msg">
<br class="gmail_msg">
> However, please keep in mind apktool takes a lot of time to run even on toy<br class="gmail_msg">
> examples<br class="gmail_msg">
<br class="gmail_msg">
Whilst I am not a fan of it slowing down this much, I think I'd<br class="gmail_msg">
prefer to see some tests in there (that we can speed up later)<br class="gmail_msg">
rather than none.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Regards,<br class="gmail_msg">
<br class="gmail_msg">
--<br class="gmail_msg">
,''`.<br class="gmail_msg">
: :' : Chris Lamb<br class="gmail_msg">
`. `'` <a href="mailto:lamby@debian.org" class="gmail_msg" target="_blank">lamby@debian.org</a> / <a href="http://chris-lamb.co.uk" rel="noreferrer" class="gmail_msg" target="_blank">chris-lamb.co.uk</a><br class="gmail_msg">
`-<br class="gmail_msg">
</blockquote></div></div></div></div></div></div>