[Rsbackup-maint] Bug#853647: rsbackup: ftbfs with GCC-7

[Matthias Klose]

Package: src:rsbackup
Version: 3.1-3
Severity: normal
Tags: sid buster
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-7

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
severity of this report may be raised before the buster release.
There is no need to fix this issue in time for the stretch release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc7-20170126/rsbackup_3.1-3_unstable_gcc7.log
The last lines of the build log are at the end of this report.

To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-7/porting_to.html

[...]
checking type of second argument to iconv()... char **
checking for pthread_create in -lpthread... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating tests/Makefile
config.status: creating doc/Makefile
config.status: creating tools/Makefile
config.status: creating config.h
config.status: executing depfiles commands
/usr/bin/make
make[1]: Entering directory '/<<PKGBUILDDIR>>'
/usr/bin/make  all-recursive
make[2]: Entering directory '/<<PKGBUILDDIR>>'
Making all in src
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
g++ -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -Wall -W -Werror -Wpointer-arith -Wwrite-strings -MT Backup.o -MD -MP -MF .deps/Backup.Tpo -c -o Backup.o Backup.cc
mv -f .deps/Backup.Tpo .deps/Backup.Po
g++ -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -Wall -W -Werror -Wpointer-arith -Wwrite-strings -MT BulkRemove.o -MD -MP -MF .deps/BulkRemove.Tpo -c -o BulkRemove.o BulkRemove.cc
mv -f .deps/BulkRemove.Tpo .deps/BulkRemove.Po
g++ -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -Wall -W -Werror -Wpointer-arith -Wwrite-strings -MT Check.o -MD -MP -MF .deps/Check.Tpo -c -o Check.o Check.cc
mv -f .deps/Check.Tpo .deps/Check.Po
g++ -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -Wall -W -Werror -Wpointer-arith -Wwrite-strings -MT Command.o -MD -MP -MF .deps/Command.Tpo -c -o Command.o Command.cc
Command.cc: In member function 'void Command::parse(int, const char* const*)':
Command.cc:138:19: error: this statement may fall through [-Werror=implicit-fallthrough=]
     case 'h': help();
               ~~~~^~
Command.cc:139:5: note: here
     case 'V': version();
     ^~~~
Command.cc:139:22: error: this statement may fall through [-Werror=implicit-fallthrough=]
     case 'V': version();
               ~~~~~~~^~
Command.cc:140:5: note: here
     case 'b': backup = true; break;
     ^~~~
cc1plus: all warnings being treated as errors
Makefile:964: recipe for target 'Command.o' failed
make[3]: *** [Command.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
Makefile:401: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
Makefile:341: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:33: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2