[Rsbackup-maint] Bug#1089421: rsbackup: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:13:49 +0100 Niels Thykier <niels at thykier.net> wrote:
> Source: rsbackup
> Version: 8.0-2
> Severity: important
> Tags: ftbfs
> Justification: FTBFS
> X-Debbugs-Cc: niels at thykier.net
> User: niels at thykier.net
> Usertags: rrr-no-as-default-issue
> 
> Dear maintainer,
> 
> During a test rebuild for building packages with
> `Rules-Requires-Root: no` as the default in `dpkg`,
> rsbackup failed to rebuild.
> 
> Log Summary:
> -------------------------------------------------------------------------------
> [...]
> 

Hi

Please see attached as a patch.

I intend to NMU to make progress on the MBF if I do not hear from you on 
this. It would help me if you either uploaded this soon or approved the 
NMU (enabling me to skip the delay). Thanks in advance.

Best regards,
Niels

-------------- next part --------------
diff -u rsbackup-8.0/debian/changelog rsbackup-8.0/debian/changelog
--- rsbackup-8.0/debian/changelog
+++ rsbackup-8.0/debian/changelog
@@ -1,3 +1,11 @@
+rsbackup (8.0-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove requirement for root when building the package.
+    (Closes: #1089421)
+
+ -- Niels Thykier <niels at thykier.net>  Wed, 01 Jan 2025 19:06:43 +0000
+
 rsbackup (8.0-2) unstable; urgency=medium
 
   * Patch from wuruilong for loong64 support (Closes: #1070106)
diff -u rsbackup-8.0/debian/control rsbackup-8.0/debian/control
--- rsbackup-8.0/debian/control
+++ rsbackup-8.0/debian/control
@@ -2,6 +2,7 @@
 Maintainer: Debian rsbackup maintainers <rsbackup-maint at lists.alioth.debian.org>
 Uploaders: Matthew Vernon <matthew at debian.org>
 Priority: optional
+Rules-Requires-Root: no
 Standards-Version: 3.9.6.0
 Section: admin
 Homepage: https://www.greenend.org.uk/rjk/rsbackup/
diff -u rsbackup-8.0/debian/rules rsbackup-8.0/debian/rules
--- rsbackup-8.0/debian/rules
+++ rsbackup-8.0/debian/rules
@@ -91,11 +91,10 @@
 			| sort | xargs md5sum > DEBIAN/md5sums
 	dpkg-gencontrol -isp -prsbackup -Pdebian/rsbackup \
 		-Tdebian/substvars.rsbackup
-	chown -R root:root debian/rsbackup
 	chmod -R g-ws debian/rsbackup
 	find debian/rsbackup -newermt "@$$SOURCE_DATE_EPOCH" -print0 | \
 		xargs -0r touch --no-dereference --date="@$$SOURCE_DATE_EPOCH"
-	dpkg --build debian/rsbackup ..
+	dpkg-deb --root-owner-group --build debian/rsbackup ..
 
 clean-rsbackup-graph:
 	rm -rf debian/rsbackup-graph
@@ -122,11 +121,10 @@
 			| xargs md5sum > DEBIAN/md5sums
 	dpkg-gencontrol -isp -prsbackup-graph -Pdebian/rsbackup-graph \
 		-Tdebian/substvars.rsbackup-graph
-	chown -R root:root debian/rsbackup-graph
 	chmod -R g-ws debian/rsbackup-graph
 	find debian/rsbackup-graph -newermt "@$$SOURCE_DATE_EPOCH" -print0 | \
 		xargs -0r touch --no-dereference --date="@$$SOURCE_DATE_EPOCH"
-	dpkg --build debian/rsbackup-graph ..
+	dpkg-deb --root-owner-group --build debian/rsbackup-graph ..
 
 binary: binary-arch binary-indep
 binary-arch: binary-rsbackup binary-rsbackup-graph
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/rsbackup-maint/attachments/20250101/aebd2af3/attachment.sig>