[sane-devel] matsushita backend

[Frank Zago]

> backend/matsushita.h:
>   * when compiling with --enable-warnings:
>   gcc -c -g -O2 -W -Wall -Wcast-align -Wcast-qual
>   -Wmissing-declarations -Wmissing-prototypes -Wpointer-arith
>   -Wreturn-type -Wstrict-prototypes -pedantic -ansi -DHAVE_CONFIG_H
>   -I. -I. -I../include -I../include -D_GNU_SOURCE
>   -DPATH_SANE_CONFIG_DIR=/usr/local/etc/sane.d
>   -DPATH_SANE_DATA_DIR=/usr/local/share -DV_MAJOR=1 -DV_MINOR=0
>   -DBACKEND_NAME=matsushita -DLIBDIR=/usr/local/lib/sane matsushita.c
>   -fPIC -DPIC -o .libs/matsushita.lo
>   In file included from matsushita.c:83:
>   matsushita.h:144: syntax error before int'

Strange. I don't get this one. And the same code exists in several
backends. Are you using a special version of gcc? Mine is
  #gcc -v
  Reading specs from /usr/lib/gcc-lib/i486-suse-linux/2.95.2/specs
  gcc version 2.95.2 19991024 (release)

Other warning fixed.

> Generally: use GNU indent :-) At least it looks like you use tabsize=2
>            or like very big indents

Actually it's tabsize=4.

> I haven't checked yet on other platforms but Linux/i386 but I don't
> expect too much trouble.

It compiles on hpux 11, aix 4.3 and 5.1.

> This is probably the shortest list of annotations for a new backend
> until now. Very good!

So the next one will have to be perfect! :)

Thanks for the review,
  Frank.

--
Frank Zago - Gresham Enterprise Storage - www.greshamstorage.com