[sane-devel] [RFC] [PATCH] scanadf [ -p | --pipe ] option

[Henning Meier-Geinitz]

Hi,

On Mon, Jul 11, 2005 at 01:40:17PM +0200, Rene Rebe wrote:
> It also changes to wait(pid) for the script in any case as well as not 
> ignore SIGCHLD - one of those interacted badly with my avision backend. 
> I'll review the details before a possible commit.

Also check CVS, there is a change concerning waiting for the scripts
to be finished before exiting. This makes your patch fail (one hunk).

> Any comments?

Use indent -gnu :-)

And:

> +    case 0:
> +	/*  in child process  */
> +	if (use_pipe) {
> +	 dup2(pipefd[0],0); close(pipefd[0]); close(pipefd[1]);
> +	}
> +	sprintf(cmd, "%s '%s'", script, fname);

I think this line (and cmd) is useless now (and was before your change).

Bye,
  Henning