[sane-devel] Completed HP ScanJet 3500C backend

[Henning Meier-Geinitz]

Hi,

On Sun, Nov 27, 2005 at 03:27:04PM +1100, Troy Rollo wrote:
> The attached patch adds support for the HP ScanJet 3500 series, including the 
> 3500C, 3530C and 3570C. It passes scanimage -T (both locally and via saned), 
> and I have been using it locally for a few months now with no problems.

Thanks for your work! Do you have a website where you can place the
patch? Otherwise I'd put it somewhere on my site and update the links
on the SANE web site. At the moment we are in feature freeze so the
backend can only be added after the next release.

Some comments below:

Compilation warnings:
hp3500.c: In function 'do_reset':
hp3500.c:986: warning: unused parameter 'scanner'
hp3500.c: In function 'rt_execute_commands':
hp3500.c:1105: warning: pointer targets in passing argument 2 of 'sanei_usb_write_bulk' differ in signedness
hp3500.c:1117: warning: pointer targets in passing argument 2 of 'sanei_usb_read_bulk' differ in signedness
hp3500.c: In function 'rt_set_register_immediate':
hp3500.c:1220: warning: pointer of type 'void *' used in arithmetic
hp3500.c:1220: warning: pointer of type 'void *' used in arithmetic
hp3500.c: At top level:
hp3500.c:1329: warning: function declaration isn't a prototype
hp3500.c: In function 'rts8801_doscan':
hp3500.c:2227: warning: unused parameter 'calib_info'
hp3500.c: In function 'rts8801_fullscan':
hp3500.c:2435: warning: pointer targets in passing argument 3 of 'rt_nvram_read' differ in signedness
hp3500.c:2398: warning: unused parameter 'red_calib_offset'
hp3500.c:2399: warning: unused parameter 'green_calib_offset'
hp3500.c:2400: warning: unused parameter 'blue_calib_offset'
hp3500.c: In function 'rts8801_scan':
hp3500.c:2698: warning: pointer targets in passing argument 1 of 'rt_detect_sram' differ in signedness
hp3500.c:2682: warning: unused variable 'aiLowOffset'
hp3500.c:2681: warning: unused variable 'aiLowTotals'

First test:
scanimage -L
scanimage: symbol lookup error: /usr/local/lib/sane/libsane-hp3500.so.1: undefined symbol: sanei_thread_init

backend/Makefile.in needs an additional:
libsane-hp3500.la: ../sanei/sanei_thread.lo

doc/backend-writing.txt says:
* Include sanei_backend.h after the other includes.

I think order is important on some platforms.

> +++ doc/sane.man	27 Nov 2005 01:00:31 -0000
> @@ -796,6 +796,7 @@
>  .BR sane-gt68xx (5),
>  .BR sane-hp (5),
>  .BR sane-hpsj5s (5),
> +.BR sane-hp3500 (5),
>  .BR sane-hp4200 (5),
>  .BR sane-hp5400 (5),
>  .BR sane-ibm (5),

Please also add a line to sane.man describing your backend (see the
other backends for examples).

Bye,
  Henning